test: add recordings for new export tests#155
Open
v-alexmoraru wants to merge 4 commits intomicrosoft:mainfrom
Open
test: add recordings for new export tests#155v-alexmoraru wants to merge 4 commits intomicrosoft:mainfrom
v-alexmoraru wants to merge 4 commits intomicrosoft:mainfrom
Conversation
ayeshurun
reviewed
Feb 5, 2026
Comment on lines
+104
to
+115
| @pytest.mark.parametrize("item_type", [ | ||
| ItemType.NOTEBOOK, | ||
| ItemType.SPARK_JOB_DEFINITION, | ||
| ItemType.DATA_PIPELINE, | ||
| ItemType.MIRRORED_DATABASE, | ||
| ItemType.REPORT, | ||
| ItemType.SEMANTIC_MODEL, | ||
| ItemType.KQL_DATABASE, | ||
| ItemType.COSMOS_DB_DATABASE, | ||
| ItemType.USER_DATA_FUNCTION, | ||
| ItemType.GRAPH_QUERY_SET | ||
| ]) |
Collaborator
There was a problem hiding this comment.
how can we maintain one list instead of defining anytime new mark.parametrize ? i am trying to think how we will maintain it going forward
ayeshurun
reviewed
Feb 5, 2026
Comment on lines
+56
to
+64
| @pytest.mark.parametrize("item_type,expected_file_extension", [ | ||
| (ItemType.NOTEBOOK, ".ipynb"), | ||
| (ItemType.SPARK_JOB_DEFINITION, ".json"), | ||
| (ItemType.DATA_PIPELINE, ".json"), | ||
| (ItemType.MIRRORED_DATABASE, ".json"), | ||
| (ItemType.COSMOS_DB_DATABASE, ".json"), | ||
| (ItemType.USER_DATA_FUNCTION, ".json"), | ||
| (ItemType.GRAPH_QUERY_SET, ".json") | ||
| ]) |
Collaborator
There was a problem hiding this comment.
is this the same as above ? if yes, let's define in conftest and use it here and above.
btw, i think it will be best to concentrate all markers like this one in conftest, even if they are too specific for the scenario - perhaps we can name them according to the scenario they are being used. this way we will have one place to maintain and strightforward decision what items i want to add / update.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.